New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io/ioutil: possible legal issue with random number generator #14773
Comments
The line in question is Line 32 in 5fea2cc
|
Thanks. I will check with our open source lawyers. |
Hey perillo, Thanks for your concern. A few things:
You suggested the following fix: We should not do this. This would simply hide where the constants came from. This makes it seem like something wrong has happened here, but nothing bad has actually happened. Instead, we are comfortable with what happened here - reuse of two well known mathematical constants. We should keep this comment as-is and close this issue. |
Thanks, Danny. |
The random number generator used in ioutil package is the
ranqd1
function implemented in Numerical Recipes. The problem with Numerical Recipes is that all the code is under copyright, and it is illegal to use it inside the Go standard library.I suggest to replace the comment
// constants from Numerical Recipes
with something likethe constant a has been suggested by Knuth and the constant b has been extensively tested by H.W. Lewis
.The text was updated successfully, but these errors were encountered: