-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/compile: obj.As type broke compilebench #14720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@josharian sorry about that. What is compilebench? Where are its sources? I'll send you a PR. |
@josharian I'm not able to repro your failure. Do you mind double checking that your source tree is in a consistent state? In particular, that error message only looks possible if only half of CL 20350 was applied to your source tree somehow: CL 20350 both changed |
Huh. Looks like compilebench needs to be compiled with (roughly) the same Go version as it is benchmarking. Mine was built with 1.6. Pity, because I'd rather use a stable release to build my tools, but...I'm going to call this wontfix for now. |
@josharian FYI, I'm able to reproduce your failure if I build compilebench using ~/go15 (which is not on my PATH), but then try to use it to benchmark the compiler from ~/go (which is). What seems to happen is:
One workaround is to run compilebench as "GOROOT=$(go env GOROOT) compilebench". |
CL 20350 broke compilebench. As of that CL:
cc @mdempsky @davecheney @bradfitz
The text was updated successfully, but these errors were encountered: