Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestDialerDualStackFDLeak i/o timeout #14717

Closed
bradfitz opened this issue Mar 8, 2016 · 6 comments
Closed

net: TestDialerDualStackFDLeak i/o timeout #14717

bradfitz opened this issue Mar 8, 2016 · 6 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.7Maybe

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Mar 8, 2016

TestDialerDualStackFDLeak is still flaky, at least on openbsd.

I see these often: (@aclements, stats?)

https://storage.googleapis.com/go-build-log/e649481c/openbsd-386-gce58_73f861b3.log

...
ok      mime/multipart  1.551s
ok      mime/quotedprintable    1.366s
--- FAIL: TestDialerDualStackFDLeak (0.12s)
    dial_test.go:213: dial tcp 127.0.0.1:19773: i/o timeout
FAIL
FAIL    net 8.870s
...

(Related previous deflaking effort for this func was in #14223, but that was apparently not about i/o timeouts)

@mikioh, can you deflake? And if not, can we just disable that test on OpenBSD? Flaky tests do more harm than good.
@bradfitz bradfitz added this to the Go1.7 milestone Mar 8, 2016
@aclements
Copy link
Member

Maybe I'm not filtering this well enough, but this doesn't seem OpenBSD-specific at all:

$ greplogs -dashboard -md -l -E 'dial tcp.*i/o timeout' -E TestDialerDualStackFDLeak | tail -n 20
2016-02-24T22:19:56-e173ab1/dragonfly-amd64
2016-02-24T22:54:41-0625fc8/dragonfly-amd64
2016-02-25T00:21:14-45c4ebe/dragonfly-amd64
2016-02-25T00:38:16-9e173f9/dragonfly-amd64
2016-02-25T03:11:55-7c90abe/dragonfly-amd64
2016-02-25T03:14:01-4accfe1/dragonfly-amd64
2016-02-25T07:10:07-fb54e03/dragonfly-amd64
2016-02-25T18:57:28-db44223/dragonfly-amd64
2016-02-25T19:11:55-d44088f/dragonfly-amd64
2016-02-26T01:46:07-e0fa809/netbsd-386-minux
2016-02-26T15:45:45-bdc1469/netbsd-386-minux
2016-02-26T19:06:38-90fea9d/netbsd-386-minux
2016-02-26T19:07:16-b462744/netbsd-386-minux
2016-02-26T19:21:32-c747fce/netbsd-386-minux
2016-02-26T22:01:16-3c0fae5/netbsd-386-minux
2016-02-26T22:45:21-6abc8c9/netbsd-386-minux
2016-02-29T02:33:26-28ce6f3/freebsd-arm-paulzhol
2016-03-02T00:49:39-a8d4463/freebsd-arm-paulzhol
2016-03-05T02:33:00-72d90d8/dragonfly-amd64
2016-03-07T22:40:50-40e60e7/freebsd-arm-paulzhol

There are OpenBSD failures further back.

$ greplogs -dashboard -l -E 'dial tcp.*i/o timeout' -E TestDialerDualStackFDLeak | sed 's,.*/,,' | sort | uniq -c
     48 dragonfly-amd64
      1 freebsd-386-gce101
     17 freebsd-arm-paulzhol
      1 linux-386
      1 linux-amd64-race
     43 netbsd-386-minux
      8 openbsd-386-gce56
      4 openbsd-386-gce58
      2 openbsd-amd64-gce56

@bradfitz bradfitz changed the title net: TestDialerDualStackFDLeak i/o timeout on OpenBSD net: TestDialerDualStackFDLeak i/o timeout Mar 8, 2016
@bradfitz
Copy link
Contributor Author

bradfitz commented Mar 8, 2016

Thanks. Removed OpenBSD-specific stuff from this bug.

@mikioh
Copy link
Contributor

mikioh commented Mar 9, 2016

I guess this is a sign that indicates that the current Dialer{DualStack: true} has some potential flaw, especially on the platforms which never allow IP dual stack sockets using IPv6 IPv4-mapped addresses. Will investigate after fixing #11837 and #13360.

@mdempsky
Copy link
Member

Related: #13324 and #15157.

@mikioh mikioh removed their assignment May 6, 2016
@mikioh mikioh added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 11, 2016
@mikioh mikioh modified the milestones: Go1.7Maybe, Go1.7 May 19, 2016
@mikioh
Copy link
Contributor

mikioh commented May 19, 2016

Maybe relaxing max wait duration mitigate TestDialerDualStackFDLeak.

@gopherbot
Copy link

CL https://golang.org/cl/23244 mentions this issue.

@golang golang locked and limited conversation to collaborators May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.7Maybe
Development

No branches or pull requests
5 participants
@bradfitz @mdempsky @mikioh @aclements @gopherbot