Skip to content

os/user: warning building on mac #14696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robpike opened this issue Mar 7, 2016 · 4 comments
Closed

os/user: warning building on mac #14696

robpike opened this issue Mar 7, 2016 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@robpike
Copy link
Contributor

robpike commented Mar 7, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

go version devel +8969ab8 Mon Mar 7 22:41:22 2016 +0000 darwin/amd64

  1. What operating system and processor architecture are you using (go env)?

mac osx 10.11.3

gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/c++/4.2.1
Apple LLVM version 7.0.0 (clang-700.0.72)
Target: x86_64-apple-darwin15.3.0
Thread model: posix

  1. What did you do?

./make.bash. I am now seeing

os/user/lookup_unix.go:43:35: warning: passing 'gid_t *' (aka 'unsigned int *') to parameter of type 'int *' converts between pointers to integer types with different sign [-Wpointer-sign]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/unistd.h:653:43: note: passing argument to parameter here
@bradfitz
Copy link
Contributor

bradfitz commented Mar 7, 2016

Ross, can you take a look? I see the same thing on my mac.

(To be clear, it's a compiler warning during make.bash, not a fatal error, which is probably why we didn't catch it; C warnings are basically the only warnings that exist and are allowed to spam in a Go build)

@bradfitz bradfitz added this to the Go1.7 milestone Mar 7, 2016
@cespare cespare mentioned this issue Mar 7, 2016
Closed
@josharian josharian mentioned this issue Mar 7, 2016
Closed
@zombiezen
Copy link
Contributor

Taking a look now. For the future, should the build bots (or at least, try bots) error on C warnings?

@bradfitz
Copy link
Contributor

bradfitz commented Mar 7, 2016

@zombiezen, that is the topic of #14698

@josharian josharian mentioned this issue Mar 8, 2016
Closed
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20348 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
4 participants
@bradfitz @zombiezen @robpike @gopherbot