Skip to content

crypto/x509: oidSignatureDSAWithSHA256 has incorrect value #14663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AGWA opened this issue Mar 5, 2016 · 2 comments
Closed

crypto/x509: oidSignatureDSAWithSHA256 has incorrect value #14663

AGWA opened this issue Mar 5, 2016 · 2 comments
Labels
FrozenDueToAge

Comments

@AGWA
Copy link

AGWA commented Mar 5, 2016

The value of oidSignatureDSAWithSHA256 is currently defined as:

oidSignatureDSAWithSHA256 = asn1.ObjectIdentifier{2, 16, 840, 1, 101, 4, 3, 2}

It should be:

oidSignatureDSAWithSHA256 = asn1.ObjectIdentifier{2, 16, 840, 1, 101, 3, 4, 3, 2}

per https://tools.ietf.org/html/rfc5758#section-3.1:

 id-dsa-with-sha256 OBJECT IDENTIFIER  ::=  { joint-iso-ccitt(2)
     country(16) us(840) organization(1) gov(101) csor(3)
     algorithms(4) id-dsa-with-sha2(3) 2 }.
@AGWA
Copy link
Author

AGWA commented Mar 5, 2016

This OID is also defined incorrectly in the x/crypto/ocsp package.

@agl agl self-assigned this Mar 10, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20549 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 12, 2016
@agl
crypto/x509: correct OID for DSA-with-SHA-256.
ec158ce 
I copied this down incorrectly. See
https://tools.ietf.org/html/rfc5758#section-3.1.

Thankfully it's incredibly obscure.

Fixes #14663.

Change-Id: I4792ee979916cc15aa2e300c8bc989bc4f9c63ac
Reviewed-on: https://go-review.googlesource.com/20549
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
@golang golang locked and limited conversation to collaborators Mar 13, 2017
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@agl
x/crypto/ocsp: correct OID for DSA-with-SHA-256.
b1dcb9e 
This was incorrect in crypto/x509 and go copied here.
See https://go-review.googlesource.com/#/c/20549 for the fix to
crypto/x509.

Fixes golang/go#14663.

Change-Id: I1fdca4b3f3edfeef1ee4ae01b1cf252ad8471163
Reviewed-on: https://go-review.googlesource.com/20550
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
c-expert-zigbee added a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@c-expert-zigbee
x/crypto/ocsp: correct OID for DSA-with-SHA-256.
1d77725 
This was incorrect in crypto/x509 and go copied here.
See https://go-review.googlesource.com/#/c/20549 for the fix to
crypto/x509.

Fixes golang/go#14663.

Change-Id: I1fdca4b3f3edfeef1ee4ae01b1cf252ad8471163
Reviewed-on: https://go-review.googlesource.com/20550
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@rsc rsc unassigned agl Jun 23, 2022
jasonwvh pushed a commit to jasonwvh/ocsp that referenced this issue Jul 13, 2022
@agl
x/crypto/ocsp: correct OID for DSA-with-SHA-256.
faf667a 
This was incorrect in crypto/x509 and go copied here.
See https://go-review.googlesource.com/#/c/20549 for the fix to
crypto/x509.

Fixes golang/go#14663.

Change-Id: I1fdca4b3f3edfeef1ee4ae01b1cf252ad8471163
Reviewed-on: https://go-review.googlesource.com/20550
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@agl
x/crypto/ocsp: correct OID for DSA-with-SHA-256.
08c1115 
This was incorrect in crypto/x509 and go copied here.
See https://go-review.googlesource.com/#/c/20549 for the fix to
crypto/x509.

Fixes golang/go#14663.

Change-Id: I1fdca4b3f3edfeef1ee4ae01b1cf252ad8471163
Reviewed-on: https://go-review.googlesource.com/20550
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@agl
x/crypto/ocsp: correct OID for DSA-with-SHA-256.
966ec25 
This was incorrect in crypto/x509 and go copied here.
See https://go-review.googlesource.com/#/c/20549 for the fix to
crypto/x509.

Fixes golang/go#14663.

Change-Id: I1fdca4b3f3edfeef1ee4ae01b1cf252ad8471163
Reviewed-on: https://go-review.googlesource.com/20550
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
desdeel2d0m added a commit to desdeel2d0m/crypto that referenced this issue Jul 1, 2024
@desdeel2d0m @agl
x/crypto/ocsp: correct OID for DSA-with-SHA-256.
11d1382 
This was incorrect in crypto/x509 and go copied here.
See https://go-review.googlesource.com/#/c/20549 for the fix to
crypto/x509.

Fixes golang/go#14663.

Change-Id: I1fdca4b3f3edfeef1ee4ae01b1cf252ad8471163
Reviewed-on: https://go-review.googlesource.com/20550
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agl @AGWA @gopherbot