-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: shouldn't use duffcopy and duffzero on plan9/amd64 #14605
Labels
Milestone
Comments
I proposed that we disable duffzero and duffcopy only for the runtime
package on plan 9. User packages are unaffected.
|
I've just seen the discussion on golang-dev. Your proposed solution seems good to me. |
I propose CL 20171 to disable the use of duffcopy and duffzero entirely on Plan 9, for now. |
CL https://golang.org/cl/20171 mentions this issue. |
Should we introduce ssa.Config. NoDuffDevice field and use that instead of
isPlan9 package level variable?
|
gopherbot
pushed a commit
that referenced
this issue
Mar 3, 2016
The ssa compiler uses the duffcopy and duffzero functions, which rely on the MOVUPS instructions. However, this doesn't work on Plan 9, since floating point operations are not allowed in the note handler. This change disables the use of duffcopy and duffzero on Plan 9 in the ssa compiler. Updates #14605. Change-Id: I017f8ff83de00eabaf7e146b4344a863db1dfddc Reviewed-on: https://go-review.googlesource.com/20171 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Can this be closed @0intro? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Since commit commit a6fb2aede7 (merge of dev.ssa branch), programs built by the Go compiler don't work anymore on plan9/amd64.
See http://build.golang.org/log/43797a52b5ed323d15f7736d8cc66ee154493a99
go_bootstrap is crashing in runtime·duffcopy, because it uses MOVUPS, while floating point instructions are not allowed in the Plan 9 note handler.
The text was updated successfully, but these errors were encountered: