Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: SSA, don't re-copy spilled output parameters #14586

Open
randall77 opened this issue Mar 1, 2016 · 0 comments
Open

cmd/compile: SSA, don't re-copy spilled output parameters #14586

randall77 opened this issue Mar 1, 2016 · 0 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Performance
Milestone
Unplanned

Comments

@randall77
Copy link
Contributor 

func f(a []int) (s int) {
    for _, x := range a {
        s += x
    }
    runtime.GC()
    return
}

The SSA-generated code does this after runtime.GC():

        MOVQ    "".s+32(FP), BX
        MOVQ    BX, "".s+32(FP)

We should teach the compiler that it doesn't need to move the result to the output slot if was already spilled to the correct slot.
@bradfitz bradfitz modified the milestone: Unplanned Apr 9, 2016
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Performance
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@bradfitz @randall77 @gopherbot