Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: make TestCgoCheckBytes less strict #14519

Closed
randall77 opened this issue Feb 26, 2016 · 4 comments
Closed

runtime: make TestCgoCheckBytes less strict #14519

randall77 opened this issue Feb 26, 2016 · 4 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.7

Comments

@randall77
Copy link
Contributor

I just got a "too slow" error from TestCgoCheckBytes. Any chance we could make this test lest strict?

GOMAXPROCS=2 runtime -cpu=1,2,4

--- FAIL: TestCgoCheckBytes (0.04s)
crash_cgo_test.go:178: cgo check too slow: got 32.498982ms, expected at most 24.46407ms
FAIL
FAIL runtime 31.021s
2016/02/26 03:59:26 Failed: exit status 1
2016/02/26 03:59:26 FAILED

@ianlancetaylor
@randall77 randall77 added the Testing An issue that has been verified to require only test changes, not just a test failure. label Feb 26, 2016
@randall77 randall77 added this to the Go1.7 milestone Feb 26, 2016
@ianlancetaylor
Copy link
Contributor

Are you synced past 5c096cc? Seems like you might not be.

@gopherbot
Copy link

CL https://golang.org/cl/19933 mentions this issue.

@randall77
Copy link
Contributor Author

SSA last pulled in tip at 7786f97, which looks to be 3 days ago now.

gopherbot pushed a commit that referenced this issue Feb 26, 2016
@ianlancetaylor
runtime: more deflaking of TestCgoCheckBytes
8d94b9b 
Fixes #14519.

Change-Id: I8f78f67a463e6467e09df90446f7ebd28789d6c9
Reviewed-on: https://go-review.googlesource.com/19933
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/22071 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 14, 2016
@ianlancetaylor @adg
runtime: more deflaking of TestCgoCheckBytes
e86286b 
Fixes #14519.

Change-Id: I8f78f67a463e6467e09df90446f7ebd28789d6c9
Reviewed-on: https://go-review.googlesource.com/19933
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/22071
Run-TryBot: Andrew Gerrand <adg@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
3 participants
@ianlancetaylor @randall77 @gopherbot