Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: expose fchmodat(2) on darwin/386, darwin/arm, darwin/arm64. #14457

Closed
hirochachacha opened this issue Feb 22, 2016 · 4 comments
Closed

Comments

@hirochachacha
Copy link
Contributor

AFAIK, fchmodat(2) is introduced since OS X 10.10 and IOS 8.0.

I read the related discussion:
https://groups.google.com/forum/#!topic/golang-codereviews/Fm_icdtNKe0

I cannot understand why it is restricted to amd64.

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Feb 22, 2016
@tklauser
Copy link
Member

tklauser commented Aug 9, 2017

At least for darwin/386 it was added in https://golang.org/cl/50450 (golang/sys@c4489fa).

tklauser pushed a commit to tklauser/sys that referenced this issue Aug 9, 2017
Follow golang.org/cl/50450 and add the Faccessat, Fchmodat, Fchownat,
Linkat, Mkdirat, Openat, Readlinkat, Renameat, Symlinkat and Unlinkat
functions (to conform to POSIX.1-2008) for darwin/arm and darwin/amd64.
Also add the missing AT_* constants.

Generated on Mac OS 10.11 (Darwin 15.6.0).

Also fix the mksysnum call in mkall.sh to work for darwin/arm.

Fixes golang/go#14457
@bradfitz
Copy link
Contributor

bradfitz commented Aug 9, 2017

@tklauser, I take it you're going to mail the CL for arm and arm64? (fix commit message to remove double add add first)

@tklauser
Copy link
Member

tklauser commented Aug 9, 2017

@bradfitz Yes, currently working on a CL. Thanks for the hint about commit message.

@gopherbot
Copy link

Change https://golang.org/cl/54271 mentions this issue: unix: add *at functions (POSIX.1-2008) on darwin/{arm,arm64}

micanzhang pushed a commit to micanzhang/sys that referenced this issue Sep 12, 2017
Follow golang.org/cl/50450 and add the Faccessat, Fchmodat, Fchownat,
Linkat, Mkdirat, Openat, Readlinkat, Renameat, Symlinkat and Unlinkat
functions (to conform to POSIX.1-2008) for darwin/arm and darwin/amd64.
Also add the missing AT_* constants.

Generated on Mac OS 10.11 (Darwin 15.6.0). This also regenerates the
syscall numbers for arm and arm64 akin to golang.org/cl/14151

Also fix the mksysnum call in mkall.sh to work for darwin/arm.

Fixes golang/go#14457

Change-Id: Ia3c36dbca9e6f1e4873afdfafcc4f7d8050644f9
Reviewed-on: https://go-review.googlesource.com/54271
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants