Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: [ssa] invalid instruction: 00027 #14389

Closed
OneOfOne opened this issue Feb 18, 2016 · 3 comments
Closed

cmd/compile: [ssa] invalid instruction: 00027 #14389

OneOfOne opened this issue Feb 18, 2016 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@OneOfOne
Copy link
Contributor

I'm not sure if it's alright to report SSA bugs yet, however using go version devel +bc1fb32 2016-02-17 16:31:44 +0000 linux/amd64, I end up with : <autogenerated>:9: invalid instruction: 00027 ($GOPATH/src/github.com/OneOfOne/xxhash/native/xxhash32_native.go:112) ADDL $-3688676312, AX

To reproduce:

➜ env GOPATH="/tmp/x" go get -x github.com/OneOfOne/xxhash
➜ env GOPATH="/tmp/x" go test github.com/OneOfOne/xxhash
@ianlancetaylor ianlancetaylor added this to the Go1.7 milestone Feb 18, 2016
@gopherbot
Copy link

CL https://golang.org/cl/19740 mentions this issue.

@randall77
Copy link
Contributor

Yes, please report bugs. Thanks for this one.

19740 is an immediate fix, but I think we need something more generic here. This will almost certainly happen for more than just ADD.

@tzneal

gopherbot pushed a commit that referenced this issue Feb 23, 2016
@tzneal
[dev.ssa] cmd/compile: truncate auxint when constructing Prog
c17b6b4 
The upper bits of 8/16/32 bit constants are undefined.  We need to
truncate in order to prevent x86.oclass misidentifying the size of the
constant.

Fixes #14389

Change-Id: I3e5ff79cd904376572a93f489ba7e152a5cb6e60
Reviewed-on: https://go-review.googlesource.com/19740
Reviewed-by: Keith Randall <khr@golang.org>
@randall77
Copy link
Contributor

Somehow gopherbot didn't close the issue. Todd's change is in, this should be fixed.

@golang golang locked and limited conversation to collaborators Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
4 participants
@OneOfOne @ianlancetaylor @randall77 @gopherbot