Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: go tool dist banner: incorrectly reported gobin value #14341

Closed
perillo opened this issue Feb 15, 2016 · 4 comments
Closed

cmd/dist: go tool dist banner: incorrectly reported gobin value #14341

perillo opened this issue Feb 15, 2016 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.8

Comments

@perillo
Copy link
Contributor

perillo commented Feb 15, 2016

The go tool dist banner command uses the current value of GOBIN from environment, to report the path where go commands where installed during bootstrap.

It should probably report the gobin value actually used during bootstrap, instead.
@minux
Copy link
Member

minux commented Feb 15, 2016 via email

@perillo
Copy link
Contributor Author

perillo commented Feb 15, 2016

On Mon, Feb 15, 2016 at 9:04 PM, Minux Ma notifications@github.com wrote:

When will those two GOBIN values be different?

When using go from Archlinux:

$go tool dist banner

---
Installed Go for linux/amd64 in /usr/lib/go
Installed commands in /home/manlio/.local/bin

However go core commands (go and gofmt) were installed in
/usr/lib/go/bin, not in /home/manlio/.local/bin.
Probably it is just a misunderstanding about the meaning of go command.

@ianlancetaylor ianlancetaylor added this to the Go1.7 milestone Feb 16, 2016
@ianlancetaylor ianlancetaylor changed the title go tool dist banner: incorrectly reported gobin value cmd/dist: go tool dist banner: incorrectly reported gobin value May 16, 2016
@bradfitz
Copy link
Contributor

Related? #14340 and its https://go-review.googlesource.com/23255 ("build: unset GOBIN during build")

Or not related?

@quentinmit quentinmit added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 26, 2016
@rsc rsc modified the milestones: Go1.8, Go1.7 May 27, 2016
@rsc
Copy link
Contributor

rsc commented Oct 18, 2016

Dup of #14340.

@rsc rsc closed this as completed Oct 18, 2016
@golang golang locked and limited conversation to collaborators Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
7 participants
@bradfitz @rsc @quentinmit @minux @ianlancetaylor @perillo @gopherbot