Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: GO15VENDOREXPERIMENT=0 breaks building Go #14236

Closed
dominikh opened this issue Feb 5, 2016 · 3 comments
Closed

cmd/go: GO15VENDOREXPERIMENT=0 breaks building Go #14236

dominikh opened this issue Feb 5, 2016 · 3 comments
Milestone

Comments

@dominikh
Copy link
Member

dominikh commented Feb 5, 2016

If the vendor experiment is disabled, make.bash fails to build Go with

/home/dominikh/go/src/cmd/internal/objfile/disasm.go:18:2: non-standard import "golang.org/x/arch/arm/armasm" in standard package "cmd/internal/objfile"
cmd/internal/objfile/disasm.go:18:2: cannot find package "golang.org/x/arch/arm/armasm" in any of:
    /home/dominikh/go/src/golang.org/x/arch/arm/armasm (from $GOROOT)
    /home/dominikh/prj/go/src/golang.org/x/arch/arm/armasm (from $GOPATH)
cmd/internal/objfile/disasm.go:19:2: cannot find package "golang.org/x/arch/x86/x86asm" in any of:
    /home/dominikh/go/src/golang.org/x/arch/x86/x86asm (from $GOROOT)
    /home/dominikh/prj/go/src/golang.org/x/arch/x86/x86asm (from $GOPATH)
can't load package: /home/dominikh/go/src/cmd/internal/objfile/disasm.go:18:2: non-standard import "golang.org/x/arch/arm/armasm" in standard package "cmd/internal/objfile"

because golang.org/x/arch/arm/armasm is a vendored package in the standard library.

Should the build scripts unset GO15VENDOREXPERIMENT to guarantee a sane(r) build environment?

dominikh-pc go@tags/go1.6rc2 ./src $ GOROOT_BOOTSTRAP=/usr/lib/go GO15VENDOREXPERIMENT=0 ./make.bash 
##### Building Go bootstrap tool.
cmd/dist

##### Building Go toolchain using /usr/lib/go.
bootstrap/compile/internal/big
bootstrap/internal/gcprog
bootstrap/internal/obj
bootstrap/asm/internal/flags
bootstrap/internal/obj/arm
bootstrap/internal/obj/arm64
bootstrap/internal/obj/mips
bootstrap/internal/obj/ppc64
bootstrap/internal/obj/x86
bootstrap/asm/internal/lex
bootstrap/link/internal/ld
bootstrap/asm/internal/arch
bootstrap/compile/internal/gc
bootstrap/asm/internal/asm
bootstrap/asm
bootstrap/link/internal/arm
bootstrap/link/internal/mips64
bootstrap/link/internal/ppc64
bootstrap/link/internal/amd64
bootstrap/link/internal/arm64
bootstrap/link/internal/x86
bootstrap/link
bootstrap/compile/internal/amd64
bootstrap/compile/internal/arm
bootstrap/compile/internal/arm64
bootstrap/compile/internal/mips64
bootstrap/compile/internal/ppc64
bootstrap/compile/internal/x86
bootstrap/compile

##### Building go_bootstrap for host, linux/amd64.
runtime/internal/sys
runtime/internal/atomic
runtime
sort
unicode
math
errors
unicode/utf16
unicode/utf8
sync/atomic
internal/race
encoding
container/heap
sync
io
internal/singleflight
syscall
hash
strings
bytes
hash/adler32
strconv
bufio
path
regexp/syntax
reflect
crypto
encoding/base64
internal/syscall/windows/registry
internal/syscall/windows
time
crypto/sha1
regexp
os
encoding/binary
path/filepath
os/signal
fmt
io/ioutil
os/exec
debug/dwarf
go/token
compress/flate
encoding/json
log
net/url
flag
text/template/parse
go/scanner
compress/zlib
go/ast
text/template
debug/elf
debug/macho
go/parser
go/doc
go/build
cmd/go

##### Building packages and commands for linux/amd64.
/home/dominikh/go/src/cmd/internal/objfile/disasm.go:18:2: non-standard import "golang.org/x/arch/arm/armasm" in standard package "cmd/internal/objfile"
cmd/internal/objfile/disasm.go:18:2: cannot find package "golang.org/x/arch/arm/armasm" in any of:
    /home/dominikh/go/src/golang.org/x/arch/arm/armasm (from $GOROOT)
    /home/dominikh/prj/go/src/golang.org/x/arch/arm/armasm (from $GOPATH)
cmd/internal/objfile/disasm.go:19:2: cannot find package "golang.org/x/arch/x86/x86asm" in any of:
    /home/dominikh/go/src/golang.org/x/arch/x86/x86asm (from $GOROOT)
    /home/dominikh/prj/go/src/golang.org/x/arch/x86/x86asm (from $GOPATH)
can't load package: /home/dominikh/go/src/cmd/internal/objfile/disasm.go:18:2: non-standard import "golang.org/x/arch/arm/armasm" in standard package "cmd/internal/objfile"
@bradfitz
Copy link
Contributor

bradfitz commented Feb 5, 2016

Similar to #13961, but different.

@bradfitz bradfitz changed the title GO15VENDOREXPERIMENT=0 breaks building Go cmd/go: GO15VENDOREXPERIMENT=0 breaks building Go Feb 5, 2016
@bradfitz bradfitz added this to the Go1.6 milestone Feb 5, 2016
@rsc
Copy link
Contributor

rsc commented Feb 5, 2016

Will fix.

@gopherbot
Copy link

CL https://golang.org/cl/19384 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 28, 2017
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants