Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: vendor submodule support depends on Git 1.8.5, breaks on RHEL 7 #14194

Closed
rsc opened this issue Feb 2, 2016 · 1 comment
Closed

cmd/go: vendor submodule support depends on Git 1.8.5, breaks on RHEL 7 #14194

rsc opened this issue Feb 2, 2016 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@rsc
Copy link
Contributor

rsc commented Feb 2, 2016

The use of git's global -C option breaks on RHEL 7 because that option was introduced in Git 1.8.5 but RHEL 7 runs Git 1.8.3.1. It's fairly easy to do without, so we probably should.

See discussion at linux-on-ibm-z@761ac75#commitcomment-15819577
@rsc rsc self-assigned this Feb 2, 2016
@rsc rsc added this to the Go1.6 milestone Feb 2, 2016
rsc referenced this issue in linux-on-ibm-z/go Feb 2, 2016
@rsc
cmd/go: fix git submodule fetch
761ac75 
Thanks to @toxeus on GitHub for the test case.

Fixes golang#12612.

Change-Id: I0c32fbe5044f3552053460a5347c062568093dff
Reviewed-on: https://go-review.googlesource.com/17974
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/19154 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 3, 2017
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
2 participants
@rsc @gopherbot