Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httputil: ReverseProxy doesn't remove Trailer header due to misspelling #14174

Closed
ghost opened this issue Feb 1, 2016 · 2 comments
Closed

net/http/httputil: ReverseProxy doesn't remove Trailer header due to misspelling #14174

ghost opened this issue Feb 1, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@ghost
Copy link

ghost commented Feb 1, 2016

go/src/net/http/httputil/reverseproxy.go

Line 113 in af15bee

"Trailers",

It says "Trailers" while it should be "Trailer"
@gopherbot
Copy link

CL https://golang.org/cl/19133 mentions this issue.

@bradfitz bradfitz added this to the Go1.7 milestone Feb 1, 2016
@bradfitz
Copy link
Contributor

bradfitz commented Feb 1, 2016

Thanks!

Sent a CL. We'll get it submitted for Go 1.7 at least, unless @rsc thinks it's okay for Go 1.6.

It's been many releases with the current bug and doesn't seem to have bitten anyone. That's probably because nobody's used trailers much until recently, with gRPC depending on them. So maybe this will become more noticeable as people start to proxy gRPC.

@golang golang locked and limited conversation to collaborators Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot