Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: assume .c files are for cgo #14123

Closed
rsc opened this issue Jan 27, 2016 · 4 comments
Closed

cmd/go: assume .c files are for cgo #14123

rsc opened this issue Jan 27, 2016 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.7Early

Comments

@rsc
Copy link
Contributor

rsc commented Jan 27, 2016

CL 19003 is kind of stupid.
It's left over from when a .c file could be intended for cgo or for the Go (Plan 9) C compiler.
The Plan 9 C compiler was removed in Go 1.5 and stayed removed in Go 1.6
(not that there was any doubt).
For Go 1.7 we could consider assuming that .c files are for cgo and remove the logic in the go command that considers they might be for the Plan 9 C compiler. Two releases is likely long enough to get people with Plan 9 C files to convert, if there were any people to begin with.

/cc @bradfitz @robpike
@rsc rsc added this to the Go1.7Early milestone Jan 27, 2016
@ianlancetaylor
Copy link
Contributor

For anybody who fixes this, note that there is a special case for files whose names start with "gcc_" in the runtime/cgo package. That special case can be removed when this is fixed. Actually it could be removed now.

@ianlancetaylor
Copy link
Contributor

(The special case is in builder.build in cmd/go/build.go.)

@bradfitz
Copy link
Contributor

https://go-review.googlesource.com/#/c/19613/5

@gopherbot
Copy link

CL https://golang.org/cl/19613 mentions this issue.

@ianlancetaylor ianlancetaylor mentioned this issue Jun 13, 2016
Closed
@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7Early
Development

No branches or pull requests
4 participants
@bradfitz @rsc @ianlancetaylor @gopherbot