Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: confusing syntax error about EOF meaning end-of-line #14071

Closed
rsc opened this issue Jan 22, 2016 · 2 comments
Closed

cmd/asm: confusing syntax error about EOF meaning end-of-line #14071

rsc opened this issue Jan 22, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.7Early

Comments

@rsc
Copy link
Contributor

rsc commented Jan 22, 2016

$ cat x.s
TEXT foo(SB), $0
JMP 1(PC) MORE TEXT HERE
RET
$ go tool asm x.s
x.s:2: expected EOF, found MORE
asm: asm: assembly of x.s failed
$

Use of EOF here to mean end-of-line is confusing.

/cc @robpike
@rsc rsc added this to the Go1.7Early milestone Jan 22, 2016
@tshprecher
Copy link
Contributor

I posted a review for the fix: https://go-review.googlesource.com/19731

New output:

$ cat test.s
TEXT foo(SB), $0
JMP 1(PC) MORE TEXT HERE
RET
$ go tool asm test.s
test.s:2: expected end of operand, found MORE
asm: assembly of test.s failed

@gopherbot
Copy link

CL https://golang.org/cl/19731 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7Early
Development

No branches or pull requests
3 participants
@rsc @tshprecher @gopherbot