Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/race: RaceWaitGroupAsMutex flaky on windows #14035

Closed
mwhudson opened this issue Jan 20, 2016 · 7 comments
Closed

runtime/race: RaceWaitGroupAsMutex flaky on windows #14035

mwhudson opened this issue Jan 20, 2016 · 7 comments
Labels
FrozenDueToAge
Milestone
Go1.6Maybe

Comments

@mwhudson
Copy link
Contributor

As seen here: http://build.golang.org/log/78ed79b153c9a6304a00d52c46523e9fa3961ad8
@bradfitz bradfitz added this to the Go1.6Maybe milestone Jan 21, 2016
@bradfitz
Copy link
Contributor

Dmitry, can you look into this one?

@bradfitz bradfitz changed the title runtime/race: RaceWaitGroupAsMutex fails on windows runtime/race: RaceWaitGroupAsMutex flaky on windows Jan 21, 2016
@bradfitz
Copy link
Contributor

Also http://build.golang.org/log/f99b0ecfca9b47a90ab75b01ebd609611af7f633

@bradfitz
Copy link
Contributor

/cc @aclements for flaky analysis?

@aclements
Copy link
Member

$ greplogs -l -md -dashboard -e 'RaceWaitGroupAsMutex *FAILED'
2016-01-20T06:10:20-9726696/windows-amd64-race
2016-01-21T17:00:42-f8f4cfa/windows-amd64-race
2016-01-21T18:41:36-754216d/windows-amd64-race

$ findflakes -grep 'RaceWaitGroupAsMutex *FAILED'
First observed 9726696 20 Jan 06:10 2016 (6 commits ago)
Last observed  754216d 21 Jan 18:41 2016 (1 commits ago)
60% chance failure is still happening
40% failure probability (3 of 6 commits)
Likely culprits:
   40% 9726696 cmd/dist: pass -tags race to go list in -race mode
   24% 5395846 cmd/compile: don't print (empty) package name in errors referring to built-ins
   14% df2a9e4 runtime/race: fix test so it compiles
    9% d9b32f0 cmd/compile: add VARLIVE to opnames list
    5% 7ce2402 cmd/compile: don't crash on invalid labeled statement
No known past failures

@mwhudson
Copy link
Contributor Author

Fingering the commit that starting running these tests again as introducing the flake is probably accurate, but not very helpful, unfortunately.

@aclements
Copy link
Member

Yeah. That's statistics for you. Just because it's statistically significant doesn't mean anyone cares. :)

Though it does show this flake was introduced at some point after 2015-05-07T21:08:29-9626561, which is around when the tests stopped running (admittedly, that was quite a while ago).

@gopherbot
Copy link

CL https://golang.org/cl/18968 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 3, 2017
@rsc rsc unassigned dvyukov Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6Maybe
Development

No branches or pull requests
5 participants
@bradfitz @mwhudson @dvyukov @aclements @gopherbot