Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/pbkdf2: move to standard library #13979

Closed
alexmullins opened this issue Jan 16, 2016 · 4 comments
Closed

x/crypto/pbkdf2: move to standard library #13979

alexmullins opened this issue Jan 16, 2016 · 4 comments

Comments

@alexmullins
Copy link

For archive/zip to support reading/writing encrypted volumes (see #12081) it needs pbkdf2 to derive encryption and authentication keys from a password. The package x/crypto/pbkdf2 would need to be moved into the standard library.

@minux
Copy link
Member

minux commented Jan 16, 2016 via email

@dsnet
Copy link
Member

dsnet commented Jan 16, 2016

Another possibility is to vendor the pbkdf2 package similar to how hpack is currently done.

Also, pbkdf2 seems to be only ~40 lines. It may make even more sense to just copy it over to archive/zip.

@alexmullins
Copy link
Author

It is a small package so moving to /internal or straight copying over works.

@bradfitz bradfitz added this to the Unplanned milestone Jan 21, 2016
@ALTree
Copy link
Member

ALTree commented May 13, 2019

I don't see this being moved to the standard library just to enable encrypted archives support in archive/zip; vendoring (or just the copy-pasting the needed functionalities) seem more likely; this can be done as a part of the work for #12081 (archive/zip: support for encrypted archives) and it can be tracked there, so I think we can safely close this issue.

@ALTree ALTree closed this as completed May 13, 2019
@golang golang locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants