Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: all.bash test cases fail when new export format is enabled #13977

Closed
griesemer opened this issue Jan 15, 2016 · 1 comment
Closed

Comments

@griesemer
Copy link
Contributor

The change https://go-review.googlesource.com/14204 (revision 67faca7) from 2/11/2015 broke a few tests in all.bash when running with the binary export format enabled (which is disabled by default). Found using git bisect.

Specifically, it appears that tests that use relative import paths (as in test/fixedbugs/bug437.dir) fail:

$ cd $GOROOT/test/fixedbugs/bug437.dir
$ go tool compile -newexport one.go && go tool compile -newexport two.go && go tool compile x.go && go tool link x.o

leads to:

type./Users/gri/go/test/fixedbugs/bug437.dir/two.S2: go.importpath./Users/gri/go/test/fixedbugs/bug437.dir/two.: not defined
type./Users/gri/go/test/fixedbugs/bug437.dir/two.S2: undefined: go.importpath./Users/gri/go/test/fixedbugs/bug437.dir/two.

Removing the following change:

https://go-review.googlesource.com/#/c/14204/54/src/cmd/compile/internal/gc/go.y

and rebuild the compiler only and then run above test, it works.

However, removing the change won't build the system from scratch.

@michaelmatloob pointed me at https://go-review.googlesource.com/#/c/14204/49..51/src/cmd/compile/internal/gc/go.y which gives some context about the offending change.

@griesemer griesemer self-assigned this Jan 15, 2016
@griesemer griesemer added this to the Go1.6Maybe milestone Jan 15, 2016
@gopherbot
Copy link

CL https://golang.org/cl/18702 mentions this issue.

@golang golang locked and limited conversation to collaborators Jan 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants