Skip to content

context: TestDeadline is flaky #13956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradfitz opened this issue Jan 14, 2016 · 6 comments
Closed

context: TestDeadline is flaky #13956

bradfitz opened this issue Jan 14, 2016 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bradfitz
Copy link
Contributor

http://build.golang.org/log/fb80b1a87de755770f8959badca24f07e10689ab

--- FAIL: TestDeadline (0.43s)
    context_test.go:235: context should have timed out
FAIL
FAIL    golang.org/x/net/context    3.149s

/cc @okdave @Sajmani or whoever owns this
@bradfitz bradfitz added this to the Unreleased milestone Jan 21, 2016
@okdave
Copy link
Contributor

okdave commented Feb 2, 2016

@bradfitz – is there a way to grep the builder's outputs? As far as I can see this is only flaky in win 386, but that's based on random sampling failures. I can't repro it locally in linux x64 yet.

Taking a look at the code now, but I'm not too familiar with it so might take a while.

@bradfitz
Copy link
Contributor Author

bradfitz commented Feb 2, 2016

@aclements has such powers. See x/build/cmd/fetchlogs. Austin also has more tools (not checked in?).

@aclements
Copy link
Member

Fetchlogs doesn't grab the subrepos and findflakes doesn't know how to deal with them either. :/

@bcmills
Copy link
Contributor

bcmills commented Feb 24, 2020 •
edited
Loading

Fetchlogs doesn't grab the subrepos and findflakes doesn't know how to deal with them either. :/

That's (at least partially) #35515.

Fortunately, context is now in the standard library. Unfortunately, TestDeadline is still a bit flaky.

2020-02-21T20:28:45-675a2e7/solaris-amd64-oraclerel
2019-11-01T01:51:26-efd395f/openbsd-amd64-62
2019-10-10T13:56:58-46b7557/solaris-amd64-oraclerel
2019-09-26T18:46:30-9740b60/solaris-amd64-oraclerel

@bcmills bcmills changed the title x/net/context: flaky test context: TestDeadline is flaky Feb 24, 2020
@bcmills bcmills modified the milestones: Unreleased, Backlog Feb 24, 2020
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 24, 2020
@bcmills
Copy link
Contributor

bcmills commented Mar 11, 2020

2020-03-11T16:49:13-cf82fea/solaris-amd64-oraclerel

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/223019 mentions this issue: context: deflake time-sensitive tests

@golang golang locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@bradfitz @okdave @aclements @bcmills @gopherbot