Skip to content

runtime: fatal errors on dragonfly #13947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikioh opened this issue Jan 14, 2016 · 12 comments
Closed

runtime: fatal errors on dragonfly #13947

mikioh opened this issue Jan 14, 2016 · 12 comments
Labels
FrozenDueToAge OS-Dragonfly
Milestone
Go1.6

Comments

@mikioh
Copy link
Contributor

mikioh commented Jan 14, 2016

The recent logs display the following:
@mikioh mikioh added this to the Go1.6 milestone Jan 14, 2016
@bradfitz
Copy link
Contributor

It seems that dragonfly was still happy until @ianlancetaylor's recent a7cad52 (runtime: preserve signal stack when calling Go on C thread).

Ian, can you take a look?

@ianlancetaylor
Copy link
Member

I'm not sure I would single out that particular change. After that change, the builder consistently timed out and looked flaky. The first time I see an error other than a timeout or a SIGTRAP signal was in http://build.golang.org/log/d8be87e27545cca84e8d0721c7b663ddb15ac7e4 for the change d75acd6 (which was clearly not the cause). So I think the error could have been introduced anywhere between those two changes, which is unfortunately a fair amount of ground.

@mikioh mikioh mentioned this issue Jan 14, 2016
Closed
@ianlancetaylor
Copy link
Member

I've been trying to figure out this by deduction and by looking at the source code, but no luck. gomote doesn't support DragonFly. @mikioh is there a way I can ssh on to your Dragonfly system and run tests?

@mikioh
Copy link
Contributor Author

mikioh commented Jan 17, 2016

@ianlancetaylor,

Sorry I cannot provide you with easy access to my netbsd/dragonfly VMs. I'm happy to try your patch for investigation if you can send it me off-list.

@ianlancetaylor
Copy link
Member

@mikioh I don't have a patch. I don't understand how these errors are possible. I need to have a system that I can use to investigate the problem interactively.

@kaey
Copy link

kaey commented Jan 20, 2016

62c280a - builds ok
a7cad52 - fatal error: unexpected signal during runtime execution
I've emailed credentials for a dragonfly-current server to @ianlancetaylor

@mikioh
Copy link
Contributor Author

mikioh commented Jan 20, 2016

Thanks. I think I've found out the root cause of this issue: https://go-review.googlesource.com/#/c/18715.

@kaey
Copy link

kaey commented Jan 20, 2016

@mikioh All tests passed with your patch applied. Thanks.

% uname -a
DragonFly kulikov-dragonfly.naukanet.ru 4.5-DEVELOPMENT DragonFly v4.5.0.377.g8b5a57-DEVELOPMENT #1: Wed Jan 20 15:49:06 MSK 2016     root@kulikov-dragonfly.naukanet.ru:/usr/obj/usr/src/sys/X86_64_GENERIC  x86_64

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/18716 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/18776 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/18814 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/29971 mentions this issue.

gopherbot pushed a commit that referenced this issue Sep 28, 2016
@cixtor
runtime, runtime/cgo: revert CL 18814; don't drop signal stack in new…
a0d330f 
… thread on dragonfly

This change reverts CL 18814 which is a workaroud for older DragonFly
BSD kernels, and fixes #13945 and #13947 in a more general way the
same as other platforms except NetBSD.

This is a followup to CL 29491.

Updates #16329.

Change-Id: I771670bc672c827f2b3dbc7fd7417c49897cb991
Reviewed-on: https://go-review.googlesource.com/29971
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Sep 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Dragonfly
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
5 participants
@bradfitz @mikioh @ianlancetaylor @kaey @gopherbot