Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: TestMathBigDivide is flaky on FreeBSD #13943

Closed
bradfitz opened this issue Jan 13, 2016 · 4 comments
Closed

runtime/pprof: TestMathBigDivide is flaky on FreeBSD #13943

bradfitz opened this issue Jan 13, 2016 · 4 comments
Labels
FrozenDueToAge OS-FreeBSD
Milestone
Go1.6Maybe

Comments

@bradfitz
Copy link
Contributor

https://storage.googleapis.com/go-build-log/e3e88a69/freebsd-amd64-gce101_29908d64.log

--- FAIL: TestMathBigDivide (0.49s)
    pprof_test.go:97: profile too short: [0x0 0x3 0x0 0x2710 0x0 0x0 0x1 0x0]
FAIL
FAIL    runtime/pprof   2.557s
@ianlancetaylor
Copy link
Contributor

Isn't this kind of the same as #13846 ?

@ianlancetaylor ianlancetaylor added this to the Go1.6Maybe milestone Jan 14, 2016
@bradfitz
Copy link
Contributor Author

Kind of. They both use testCPUProfile. I was going to send out a CL moving the if-crappy-timer-OS conditionals to testCPUProfile instead, but it didn't feel totally right. The comments didn't exactly belong in the new place, so I'm letting Austin decide.

@mikioh mikioh changed the title runtime/pprof: TestMathBigDivide is flaky on FreeBBSD runtime/pprof: TestMathBigDivide is flaky on FreeBSD Jan 14, 2016
@aclements
Copy link
Member

Isn't this kind of the same as #13846 ?

I can't be positive without checking the timer behavior of that benchmark, but I'd be surprised if it was anything different.

I'm weary of putting a huge blacklist (or a small whitelist) in all of the profiling tests. For most of these, I think we should instead back off and just try running it for longer if we get an empty profile. We've seen flakes all over the profiling tests and I suspect some of them are just because we're running a bunch of other package tests in parallel and the profile test genuinely doesn't get enough CPU time to get samples.

@gopherbot
Copy link

CL https://golang.org/cl/18683 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-FreeBSD
Projects
None yet
Milestone
Go1.6Maybe
Development

No branches or pull requests
5 participants
@bradfitz @mikioh @aclements @ianlancetaylor @gopherbot