-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: "stupid shift" might offend somebody #13940
Comments
This is ridiculous. |
offensive shift |
This is not a ridiculous complaint for a "stupid" appearing in an error message, but "ridiculous shift" is also a fractionally better way of phrasing it. Putting it in an error message is slightly insulting to the user, whereas comments or method names in the compiler itself are less so. "Overflowing shift" or "Shift beyond word length" are both better ways of saying it (IMO), since they provide more information about what is stupid/ridiculous about the shift. |
"invalid negative shift count" |
CL https://golang.org/cl/20081 mentions this issue. |
Updates #13940. Change-Id: I41974c292dd981d82ac03b9b8b406713445362c3 Reviewed-on: https://go-review.googlesource.com/20081 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(I'm not personally offended but others may be and in the spirit of the Code of Conduct this should probably be fixed and the code scanned for other potentially offensive words; code comments should also be kept clean)
http://play.golang.org/p/GTaPuKn5JX
https://github.com/golang/go/search?utf8=%E2%9C%93&q=stupid
The text was updated successfully, but these errors were encountered: