Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: "stupid shift" might offend somebody #13940

Closed
bits01 opened this issue Jan 13, 2016 · 5 comments
Closed

cmd/compile: "stupid shift" might offend somebody #13940

bits01 opened this issue Jan 13, 2016 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@bits01
Copy link

bits01 commented Jan 13, 2016

(I'm not personally offended but others may be and in the spirit of the Code of Conduct this should probably be fixed and the code scanned for other potentially offensive words; code comments should also be kept clean)

http://play.golang.org/p/GTaPuKn5JX

https://github.com/golang/go/search?utf8=%E2%9C%93&q=stupid
@ianlancetaylor ianlancetaylor added this to the Go1.7 milestone Jan 13, 2016
@bradfitz bradfitz changed the title Replace offensive words in messages cmd/compile: "stupid shift" might offend somebody Jan 14, 2016
@AeroNotix
Copy link
Contributor

This is ridiculous.

@griesemer
Copy link
Contributor

offensive shift

@dr2chase
Copy link
Contributor

dr2chase commented Feb 4, 2016

This is not a ridiculous complaint for a "stupid" appearing in an error message, but "ridiculous shift" is also a fractionally better way of phrasing it. Putting it in an error message is slightly insulting to the user, whereas comments or method names in the compiler itself are less so.

"Overflowing shift" or "Shift beyond word length" are both better ways of saying it (IMO), since they provide more information about what is stupid/ridiculous about the shift.

@ianlancetaylor
Copy link
Contributor

"invalid negative shift count"
"integer constant overflow"

@griesemer griesemer self-assigned this Feb 5, 2016
@gopherbot
Copy link

CL https://golang.org/cl/20081 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 1, 2016
@mdempsky
go/types: nicer shift error message
8ad027c 
Updates #13940.

Change-Id: I41974c292dd981d82ac03b9b8b406713445362c3
Reviewed-on: https://go-review.googlesource.com/20081
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Mar 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
6 participants
@AeroNotix @dr2chase @ianlancetaylor @griesemer @gopherbot @bits01