Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: UnixListener auto unlinks socket files behavior should be changeable #13877

Closed
absolute8511 opened this issue Jan 8, 2016 · 5 comments
Closed

net: UnixListener auto unlinks socket files behavior should be changeable #13877

absolute8511 opened this issue Jan 8, 2016 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@absolute8511
Copy link

The unlink flag should be designed as changeable from outside to avoid auto unlink unix domain socket file. It can be useful while implementing the graceful restart. The graceful restart need the new process listen on the same file and then close the old one. If the old one auto unlink the socket file, it will cause the socket listened by the new process is not available from the client.
The graceful restart can be found here https://github.com/facebookgo/grace
@absolute8511 absolute8511 changed the title net: UnixListener auto unlinks socket files behavious should be changeable net: UnixListener auto unlinks socket files behavior should be changeable Jan 8, 2016
@ianlancetaylor ianlancetaylor added this to the Go1.7 milestone Jan 8, 2016
@danp
Copy link
Contributor

danp commented Apr 12, 2016

Should this be accomplished by making UnixListener.unlink public?

@absolute8511
Copy link
Author

Maybe an option for auto unlink and a public method would be great. (just like FD_CLOEXEC)

@bradfitz bradfitz modified the milestones: Go1.7Maybe, Go1.7 Apr 18, 2016
@rsc
Copy link
Contributor

rsc commented May 17, 2016

Too late for new API.

@rsc rsc modified the milestones: Go1.8, Go1.7Maybe May 17, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 7, 2016
@quentinmit
Copy link
Contributor

See also #17131

@gopherbot
Copy link

CL https://golang.org/cl/32099 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
7 participants
@danp @bradfitz @rsc @quentinmit @absolute8511 @ianlancetaylor @gopherbot