-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/pprof: disable profiling test on Windows too? #13871
Comments
Windows is known to have reduced timer resolution, though it can't have the common Unix problem of only delivering profiling signals after a full time slice because the Windows APIs couldn't express a bug like that. I don't see any Windows profiling failures on the dashboard. Could this be related to whatever CL produced that failure? |
If you paste the git rev at the top of that failure log into Gerrit, Gerrit redirects you to the CL it was part of: https://go-review.googlesource.com/#/c/18374/ (an HTTP header validation change) So, no... it was a flake. |
Go profiler is not using signal on Windows. It is running on a separate dedicated OS thread. The thread is running with THREAD_PRIORITY_HIGHEST to make it as reliable as possible, but ... Also the thread is only started on demand - maybe there is some latency to that when CPU is busy. Alex |
Also maybe there is merit to https://go-review.googlesource.com/#/c/11478. @dvyukov said it is not needed, so I abandoned the change. Alex |
CL https://golang.org/cl/18683 mentions this issue. |
It appears that Windows also can't do profiles reliably?
https://storage.googleapis.com/go-build-log/5b3db773/windows-amd64-gce_15b35da7.log
(part of #13841)
The text was updated successfully, but these errors were encountered: