Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/asm: new x86 instructions #13822

Closed
rsc opened this issue Jan 5, 2016 · 8 comments
Closed

cmd/asm: new x86 instructions #13822

rsc opened this issue Jan 5, 2016 · 8 comments

Comments

@rsc
Copy link
Contributor

rsc commented Jan 5, 2016

We've had a request on golang-dev for

LDDQU
PSLLDQ
PSRLDQ
PMOVZXBD
PMULLD
PHADDD
PADDD
CVTDQ2PS

@rsc rsc added this to the Go1.6Maybe milestone Jan 5, 2016
@gopherbot
Copy link

CL https://golang.org/cl/18312 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/18311 mentions this issue.

@rsc
Copy link
Contributor Author

rsc commented Jan 6, 2016

Also HADDPS, HADDPD.

gopherbot pushed a commit that referenced this issue Jan 14, 2016
This will allow the compiler to crunch Prog lists down to code as each
function is compiled, instead of waiting until the end, which should
reduce the working set of the compiler. But not until Go 1.7.

This also makes it easier to write some machine code output tests
for the assembler, which is why it's being done now.

For #13822.

Change-Id: I0811123bc6e5717cebb8948f9cea18e1b9baf6f7
Reviewed-on: https://go-review.googlesource.com/18311
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/18823 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/18850 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/18844 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/18853 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 24, 2016
Instead of two parallel files that look almost identical,
mark the expected differences in the original file.

The annotations being added here keep the tests passing,
but they also make clear a number of printing or parsing
errors that were not as easily seen when the data was
split across two files.

Fix a few diagnostic problems in cmd/internal/obj as well.

A step toward #13822.

Change-Id: I997172681ea6fa7da915ff0f0ab93d2b76f8dce2
Reviewed-on: https://go-review.googlesource.com/18823
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Jan 24, 2016
Not much testing yet, but the test now exists.

Another step toward #13822.

Change-Id: Idb2b06bf53a6113c83008150b4c0b631bb195279
Reviewed-on: https://go-review.googlesource.com/18844
Reviewed-by: Rob Pike <r@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
gopherbot pushed a commit that referenced this issue Jan 24, 2016
Generated by x86test, from https://golang.org/cl/18842
(still in progress).

The commented out lines are either missing or misspelled
or incorrectly handled instructions.

For #4816, #8037, #13822, #14068, #14069.

Change-Id: If309310c97d9d2a3c71fc64c51d4a957e9076ab7
Reviewed-on: https://go-review.googlesource.com/18850
Reviewed-by: Rob Pike <r@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/18900 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 26, 2016
Was part of #13822 but not in the first message, so I missed it.

Fixes #13822 again.

Change-Id: I775004fa8d47b6af293124605521ec396573e267
Reviewed-on: https://go-review.googlesource.com/18900
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Jan 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants