Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/build: reverse the sense of AllowVendor #13772

Closed
aclements opened this issue Dec 29, 2015 · 3 comments
Closed

go/build: reverse the sense of AllowVendor #13772

aclements opened this issue Dec 29, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@aclements
Copy link
Member

We recently added an AllowVendor ImportMode flag to go/build. This requires go/build API users to opt-in to vendoring. Given that vendoring will be enabled by default in Go 1.6, it seems like asking for subtle bugs in users of go/build if this isn't also the default behavior of go/build.

@rsc @griesemer
@aclements aclements added this to the Go1.6 milestone Dec 29, 2015
@rsc
Copy link
Contributor

rsc commented Dec 29, 2015

My original rationale was that there might be other uses of the go/build package, in other build systems with different file tree layouts, and that silently breaking them would be bad. But on second thought that's not a concern, because the code here is looking through GOPATH and GOROOT and so is already very tied to the go command's file tree. Other build systems with different file trees wouldn't be using this code.

@rsc
Copy link
Contributor

rsc commented Dec 29, 2015

(So I agree. I'll prepare a CL.)

@gopherbot
Copy link

CL https://golang.org/cl/18450 mentions this issue.

@rsc rsc closed this as completed in ecc01a7 Jan 8, 2016
@golang golang locked and limited conversation to collaborators Jan 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
3 participants
@rsc @aclements @gopherbot