Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go install -buildmode=shared prefix/... can fail with "file name too long" #13714

Closed
mwhudson opened this issue Dec 23, 2015 · 1 comment
Closed

cmd/go: go install -buildmode=shared prefix/... can fail with "file name too long" #13714

mwhudson opened this issue Dec 23, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@mwhudson
Copy link
Contributor

Before golang.org/cl/13921 (which I sort of stopped following, bad me), "go install -buildmode=shared prefix/..." created a file called "libprefix.so", which was obviously a problem when prefix was something like "." or "../". However, now it expands the ... into all the matches packages, joins them with -, which can clearly be a very long name indeed.

We need to restore the good sort of old /... behaviour without re-introducing the bad sort.
@mwhudson mwhudson added this to the Go1.6 milestone Dec 23, 2015
@mwhudson mwhudson self-assigned this Dec 23, 2015
@gopherbot
Copy link

CL https://golang.org/cl/18114 mentions this issue.

mwhudson added a commit to mwhudson/go that referenced this issue Jan 4, 2016
@mwhudson
cmd/go: special case shared library name when passed "$prefix/..."
57b3123 
DO NOT SUBMIT (needs test fixing, but I have about 5 mins work left this year)

Before golang.org/cl/13921, "go install -buildmode=shared prefix/..." created a
file called "libprefix.so", which was obviously a problem when prefix was
something like "." or "../".  However, now it expands the ... into all the
matched packages, joins them with -, which can clearly be a very long name
indeed. Because I plan to build shared libraries for Ubuntu by running commands
exactly like "go install -buildmode=shared prefix/...", this special cases this
to produce the old behaviour (but de-relativises prefix first).

Fixes golang#13714

Change-Id: I4fd8d4934279f9a18cc70a13e4ef3e23f6abcb6e
@golang golang locked and limited conversation to collaborators Jan 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
2 participants
@mwhudson @gopherbot