Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: docs for http2 appears in package documentation #13668

Closed
ericchiang opened this issue Dec 18, 2015 · 3 comments
Closed

net/http: docs for http2 appears in package documentation #13668

ericchiang opened this issue Dec 18, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@ericchiang
Copy link
Contributor

The h2_bundle.go file doesn't remove the "http2" package documentation string here.

See the bottom of the package documentation at https://tip.golang.org/pkg/net/http/
@bradfitz
Copy link
Contributor

hah! Good find, thanks.

Alan, can you add a flag to x/tools/cmd/bundle like --break_pkg_doc which adds a newline before the package statement? Otherwise I can do it manually in my wrapper script.

/cc @alandonovan

@bradfitz bradfitz added this to the Go1.6 milestone Dec 18, 2015
@adonovan
Copy link
Member

https://go-review.googlesource.com/18040

@gopherbot
Copy link

CL https://golang.org/cl/18269 mentions this issue.

@golang golang locked and limited conversation to collaborators Jan 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
4 participants
@bradfitz @ericchiang @adonovan @gopherbot