Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: run make.bash instead of all.bash if all.bash passed previously #13663

Closed
bradfitz opened this issue Dec 17, 2015 · 3 comments
Closed

x/build/cmd/release: run make.bash instead of all.bash if all.bash passed previously #13663

bradfitz opened this issue Dec 17, 2015 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

cmd/release used to be fast and only ran make.bash.

Now it runs all.bash, which is slow.

But if all.bash already succeeded in the past there's no need to run the tests again. Maybe consult build.golang.org and ask if it already succeeded, and then switch to make.bash instead?

/cc @broady
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Dec 17, 2015
@bradfitz bradfitz self-assigned this Dec 17, 2015
@bradfitz bradfitz added this to the Unreleased milestone Dec 17, 2015
@bradfitz bradfitz removed their assignment Dec 17, 2015
bradfitz added a commit to golang/build that referenced this issue Dec 17, 2015
@bradfitz
cmd/release: add flag to skip tests
ba6d109 
Updates golang/go#13663

Change-Id: I95ecbe8d2f6c3c2799ecb81016261bc4f92ba1c9
Reviewed-on: https://go-review.googlesource.com/18013
Reviewed-by: Chris Broadfoot <cbro@golang.org>
@bradfitz
Copy link
Contributor Author

/cc @adg

@adg
Copy link
Contributor

adg commented Apr 13, 2016

I rolled the binaries yesterday and didn't think they took a particularly long time. The ARM ones, maybe. I feel like this is just optimizing for little real benefit.

Also—not that I distrust our build infrastructure, but—I feel there is some value in running the tests one last time before handing over binaries to our users.

@broady
Copy link
Member

broady commented Apr 27, 2016

This was a problem because I kept bumping into intermittent failures. Maybe those failures have stopped.

Let's re-open if releases get annoying again.

@broady broady closed this as completed Apr 27, 2016
@golang golang locked and limited conversation to collaborators Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @broady @adg @gopherbot