Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: remote buildlets don't die on TCP disconnect #13661

Closed
bradfitz opened this issue Dec 17, 2015 · 2 comments
Closed

x/build/cmd/coordinator: remote buildlets don't die on TCP disconnect #13661

bradfitz opened this issue Dec 17, 2015 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

@broady was just doing a release, hit Ctrl-C with cmd/release, and then we noticed the two buildlets that got created didn't go away when his TCP connection did. They should:

user-release-darwin-amd64-10_10-0, created 1m56.050024014s ago, expires in 28m8.113784004s
user-release-linux-arm-0, created 1m55.677042811s ago, expires in 28m4.498193149s
@bradfitz bradfitz self-assigned this Dec 17, 2015
@bradfitz bradfitz changed the title x/build/cmd/coordinator: remote buildlets don't x/build/cmd/coordinator: remote buildlets don't die on TCP disconnect Dec 17, 2015
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Dec 17, 2015
@rsc rsc added this to the Unreleased milestone Dec 28, 2015
@bradfitz
Copy link
Contributor Author

bradfitz commented Jan 7, 2016

/cc @adg if you need a probably-easy welcome-back task

@bradfitz
Copy link
Contributor Author

bradfitz commented Jun 4, 2019

This bug was confused. cmd/release uses the same interface as gomote and gomote definitely doesn't need to keep a TCP connection open to keep a buildlet open. Nothing to fix here.

@bradfitz bradfitz closed this as completed Jun 4, 2019
@golang golang locked and limited conversation to collaborators Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot