Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: ScaleValue fails to scale value with "gb" unit #13654

Closed
methane opened this issue Dec 17, 2015 · 0 comments
Closed

cmd/pprof: ScaleValue fails to scale value with "gb" unit #13654

methane opened this issue Dec 17, 2015 · 0 comments
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@methane
Copy link
Contributor

methane commented Dec 17, 2015

https://github.com/golang/go/blob/master/src/cmd/pprof/internal/report/report.go#L1501-L1511

    case "megabyte", "mb":
        value *= 1024 * 1024
    case "gigabyte", "gb":
        value *= 1024 * 1024

Last line should be value *= 1024 * 1024 * 1024.
@bradfitz bradfitz added this to the Go1.6 milestone Dec 17, 2015
@golang golang locked and limited conversation to collaborators Dec 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
3 participants
@bradfitz @methane @gopherbot