Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review: pending should not list abandoned CLs #13622

Closed
rakyll opened this issue Dec 15, 2015 · 5 comments
Closed

x/review: pending should not list abandoned CLs #13622

rakyll opened this issue Dec 15, 2015 · 5 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@rakyll
Copy link
Contributor

rakyll commented Dec 15, 2015

  1. Create a change
  2. Abandon the change
  3. git sync on the local client

git pending lists the abandoned CLs, although there isn't much value in listing them.
@rakyll rakyll added this to the Unreleased milestone Dec 15, 2015
@rakyll
Copy link
Contributor Author

rakyll commented Dec 16, 2015

Likely to be cc'ed to @adg.

@rakyll
Copy link
Contributor Author

rakyll commented Nov 3, 2016 •
edited

Current behaviour is consistent with the fact that pending subcommand is listing all local branches regardless whether they are mailed, submitted or abandoned.

Rather than hiding abandoned CLs in the listing, we should mention that they are abandoned.

$ git-codereview pending
removewiki f697cf2..ee75c4e (all mailed, 246 behind)
+ ee75c4e https://go-review.googlesource.com/32212 (mailed)
    doc: remove the link to the Learn wiki page

    The wiki page seems to be very outdated and poorly maintained. There
    are so many better resources available at this point. We shouldn't
    mention the page particularly from the golang.org docs or make sure
    it is well maintained.

    Change-Id: Iae4a3b2d7990327ca075a3a9514fa1a4dda86577

    Files in this change:
        doc/docs.html

Listing should say rather say

+ ee75c4e https://go-review.googlesource.com/32212 (mailed, abandoned)

rather than the CL is mailed.

@gopherbot
Copy link

CL https://golang.org/cl/32676 mentions this issue.

@dmitshur
Copy link
Contributor

dmitshur commented Nov 7, 2016

This issue has been resolved by golang/review@e973841 and should be closed. There was a typo in the commit message (/cc @rakyll) that prevented it from being automatically closed.

@bradfitz
Copy link
Contributor

bradfitz commented Nov 7, 2016

Thanks.

@bradfitz bradfitz closed this as completed Nov 7, 2016
@golang golang locked and limited conversation to collaborators Nov 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @rakyll @dmitshur @gopherbot