-
Notifications
You must be signed in to change notification settings - Fork 18k
internal/syscall/windows/registry: TestWalkFullRegistry fails #13500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mattn, what version of Windows are you using? |
Windows10 64bit On 12/6/15, Russ Cox notifications@github.com wrote:
|
I think this works as expected. Your C program's output is the same as Go - it returns ERROR_FILE_NOT_FOUND. I don't know why the RegOpenKeyEx fails on your computer. But I have seen all sorts of errors when reading all registry keys of various computers. People run all sorts of programs they download from Internet - buggy and shifty. These programs are free to do whatever they like with your registry - they have all your rights (more often then not administrator rights). So I do not consider failing TestWalkFullRegistry to be a problem. I have added the test while I was developing package functionality, and left it in because it is helpful sometimes to debug things. But it is only running during "go test -short", so we ignore any registry inconsistencies. Please, reopen if you disagree. Alex |
I do not have a strong opinion. It's a mental issue that all of the test is not passed. Also I am guessing that it is enough that you don't need to enumerate all of the registry. |
For the memo or knowledge. There are another problem to run this test case on non-clean environment. This is not objection to current tests. 1.
|
I don't make sure but this seems that this key is guarded on windows.
for example this return 2. Eventhough, I run this on administrator's privileges. But return 2.
/cc @alexbrainman
The text was updated successfully, but these errors were encountered: