cmd/link: remove old -X format #13498
Labels
Milestone
Comments
|
Will there still be a way to bake in compile time information into the resulting application binary? |
|
@ae6rt IIUC this is only about the old -X syntax with two arguments; the current syntax has the form |
tixxdz
pushed a commit
to endocode/fleet
that referenced
this issue
Jan 26, 2016
When building fleet with go1.5 we got the following warning: Building fleetd... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Building fleetctl... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Newer go versions will only support '-X name=value' format, so make our build system smarter. It will make sure to use the right format for future builds. Reference: golang/go#13498
tixxdz
pushed a commit
to endocode/fleet
that referenced
this issue
Jan 26, 2016
When building fleet with go1.5 we got the following warning: Building fleetd... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Building fleetctl... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Newer go versions will only support '-X name=value' format, so make our build system smarter. It will make sure to use the right format for future builds. Reference: golang/go#13498
tixxdz
pushed a commit
to endocode/fleet
that referenced
this issue
Jan 27, 2016
When building fleet with go1.5 we got the following warning: Building fleetd... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Building fleetctl... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Newer go versions will only support '-X name=value' format, so make our build system smarter. It will make sure to use the right format for future builds. Reference: golang/go#13498 Patch written by: Eugene Yakubovich https://github.com/coreos/flannel/blob/master/build
kayrus
pushed a commit
to endocode/fleet
that referenced
this issue
Mar 31, 2016
When building fleet with go1.5 we got the following warning: Building fleetd... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Building fleetctl... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Newer go versions will only support '-X name=value' format, so make our build system smarter. It will make sure to use the right format for future builds. Reference: golang/go#13498 Patch written by: Eugene Yakubovich https://github.com/coreos/flannel/blob/master/build
kayrus
pushed a commit
to endocode/fleet
that referenced
this issue
Mar 31, 2016
When building fleet with go1.5 we got the following warning: Building fleetd... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Building fleetctl... link: warning: option -X github.com/coreos/fleet/version.Version v0.10.1-117-g7b2a547 may not work in future releases; use -X github.com/coreos/fleet/version.Version=v0.10.1-117-g7b2a547 Newer go versions will only support '-X name=value' format, so make our build system smarter. It will make sure to use the right format for future builds. Reference: golang/go#13498 Patch written by: Eugene Yakubovich https://github.com/coreos/flannel/blob/master/build
|
Done in 51b624e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In Go 1.7, remove the -X option's old two-argument format from the linker.
Would fix #12338. :-)
Edit: This is about removing
-X name value, which is deprecated. The more conventional form-X name=value, first introduced in Go 1.5, would stay.The text was updated successfully, but these errors were encountered: