Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/review/git-codereview: breaks git rebase -i's "reword" option #13439

Closed
mdempsky opened this issue Dec 1, 2015 · 3 comments
Closed

x/review/git-codereview: breaks git rebase -i's "reword" option #13439

mdempsky opened this issue Dec 1, 2015 · 3 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@mdempsky
Copy link
Member

mdempsky commented Dec 1, 2015

During "git rebase -i" if you choose "reword" and try to then run "git commit --amend" to edit the commit message, you get:

$ git commit -a --amend
git rev-parse --abbrev-ref HEAD@{u}
fatal: HEAD does not point to a branch

git-codereview: exit status 128
@mdempsky mdempsky self-assigned this Dec 1, 2015
@mdempsky mdempsky added this to the Unreleased milestone Dec 1, 2015
@cmarcelo
Copy link
Contributor

When "reword" is chosen during interactive rebase, git should automatically spawn the editor for amending the commit message. Did you meant "edit"?

I've tried a bit using "edit" and things work correctly. Do you have more details on how to reproduce the issue?

@ysmolski
Copy link
Member

ysmolski commented Nov 6, 2018

I cannot reproduce this no more. I suppose it was fixed since that time...

@ysmolski ysmolski added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 6, 2018
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants