Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/webdav: D:href is not percent encoded #13286

Closed
mattn opened this issue Nov 17, 2015 · 1 comment
Closed

x/net/webdav: D:href is not percent encoded #13286

mattn opened this issue Nov 17, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@mattn
Copy link
Member

mattn commented Nov 17, 2015

https://tools.ietf.org/html/rfc4918#section-8.3.1

Also note that a legal URI may still contain characters that need to be escaped within XML character data, such as the ampersand character.

But <D:herf> doesn't. So some files can't be created on webdav.
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/16859 mentions this issue.

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Nov 17, 2015
@golang golang locked and limited conversation to collaborators Nov 27, 2016
dt-eric-lefevreardant pushed a commit to DiliTrust/go-webdav that referenced this issue Mar 11, 2025
@mattn @nigeltao
x/net/webdav: percent-encode D:href in the XML.
7169356 
Fixes golang/go#13286

Change-Id: If1e727bc18c64232b82484d9e82063cc59bcc826
Reviewed-on: https://go-review.googlesource.com/16859
Reviewed-by: Robert Stepanek <robert.stepanek@gmail.com>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mattn @ianlancetaylor @gopherbot