Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: should reject $name(SB)(reg) #13282

Closed
mwhudson opened this issue Nov 17, 2015 · 2 comments
Closed

cmd/asm: should reject $name(SB)(reg) #13282

mwhudson opened this issue Nov 17, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.6Maybe

Comments

@mwhudson
Copy link
Contributor

I don't know enough about x86 instruction encoding, but the assembler accepts syntax like MOVL foo<>(SB)(AX), AX but it is assembled identically to MOVL foo<>(SB), AX. It seems to me that either it should assemble to something different (not sure what, especially on amd64) or cause an error.
@mwhudson
Copy link
Contributor Author

FWIW, seems 8a and 6a from go 1.4 both reject this syntax.

@rsc rsc added this to the Go1.6Maybe milestone Dec 28, 2015
@rsc rsc changed the title cmd/internal/obj/x86: assembling $name(SB)(reg) ignores reg cmd/asm: should reject $name(SB)(reg) Jan 6, 2016
@gopherbot
Copy link

CL https://golang.org/cl/18858 mentions this issue.

@golang golang locked and limited conversation to collaborators Jan 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6Maybe
Development

No branches or pull requests
3 participants
@rsc @mwhudson @gopherbot