cmd/go: go install -buildmode=c-shared std does nothing
#13234
Labels
GoCommand
cmd/go
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
|
What do you think it should do? |
|
It could either exit with an error, or build the standard library with the relevant codegen args the go tool uses with -buildmode=c-shared. Silently doing nothing is odd. |
|
CL https://golang.org/cl/16928 mentions this issue. |
crawshaw
added a commit
to golang/mobile
that referenced
this issue
Nov 16, 2015
Second attempt at the change reverted in golang.org/cl/16917. The current code executes go install -buildmode=c-shared std, which does nothing. (See golang/go#13234.) Correctly compiling packages for android arm requires different flags on Go 1.5 and 1.6, as we now build PIC. So we look for go1.5 in the output of "go version", and otherwise assume 1.6+. Change-Id: If636f52be5019bd179483b8735630a98e6f8d201 Reviewed-on: https://go-review.googlesource.com/16928 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
bcmills
added
the
NeedsInvestigation
imWildCat
pushed a commit
to imWildCat/go-mobile
that referenced
this issue
Apr 10, 2021
Second attempt at the change reverted in golang.org/cl/16917. The current code executes go install -buildmode=c-shared std, which does nothing. (See golang/go#13234.) Correctly compiling packages for android arm requires different flags on Go 1.5 and 1.6, as we now build PIC. So we look for go1.5 in the output of "go version", and otherwise assume 1.6+. Change-Id: If636f52be5019bd179483b8735630a98e6f8d201 Reviewed-on: https://go-review.googlesource.com/16928 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat
pushed a commit
to imWildCat/go-mobile
that referenced
this issue
Apr 11, 2021
Second attempt at the change reverted in golang.org/cl/16917. The current code executes go install -buildmode=c-shared std, which does nothing. (See golang/go#13234.) Correctly compiling packages for android arm requires different flags on Go 1.5 and 1.6, as we now build PIC. So we look for go1.5 in the output of "go version", and otherwise assume 1.6+. Change-Id: If636f52be5019bd179483b8735630a98e6f8d201 Reviewed-on: https://go-review.googlesource.com/16928 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should it? The similar command
go install -buildmode=shared stdworks.cc @ianlancetaylor
The text was updated successfully, but these errors were encountered: