Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: builtin.go not has not been updated #13203

Closed
dspezia opened this issue Nov 11, 2015 · 2 comments
Closed

cmd/compile: builtin.go not has not been updated #13203

dspezia opened this issue Nov 11, 2015 · 2 comments
Labels
FrozenDueToAge

Comments

@dspezia
Copy link
Contributor

dspezia commented Nov 11, 2015

On tip, running go generate in src/cmd/compile/internal/gc alters file builtin.go, meaning that it has not been re-generated after a recent change.

go version devel +880a689 Wed Nov 11 06:04:04 2015 +0000 linux/amd64

It could be a consequence of CL 14204
@dspezia
Copy link
Contributor Author

dspezia commented Nov 11, 2015

Here is the diff:

diff --git a/src/cmd/compile/internal/gc/builtin.go b/src/cmd/compile/internal/gc/builtin.go
index 5b2ddbd..f1d2ac9 100644
--- a/src/cmd/compile/internal/gc/builtin.go
+++ b/src/cmd/compile/internal/gc/builtin.go
@@ -4,7 +4,6 @@ package gc

 const runtimeimport = "" +
        "package runtime\n" +
-       "import runtime \"runtime\"\n" +
        "func @\"\".newobject (@\"\".typ·2 *byte) (? *any)\n" +
        "func @\"\".panicindex ()\n" +
        "func @\"\".panicslice ()\n" +
@@ -162,7 +161,6 @@ const runtimeimport = "" +

 const unsafeimport = "" +
        "package unsafe\n" +
-       "import runtime \"runtime\"\n" +
        "type @\"\".Pointer uintptr\n" +
        "func @\"\".Offsetof (? any) (? uintptr)\n" +
        "func @\"\".Sizeof (? any) (? uintptr)\n" +

@gopherbot
Copy link

CL https://golang.org/cl/16821 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dspezia @gopherbot