-
Notifications
You must be signed in to change notification settings - Fork 18k
x/mobile: app crashed, android 2.3.6 #13172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
wasn't aware of ndk constraint on api-15. As mentioned on #13109 I believe the appropriate thing to do is abort on compilation if a manifest declares a minimum api level. The gomobile cmd should then insert the min api tag itself to whatever is decided (+2 to api-15). These are the tentative plans in the issue I linked, but it may be a month or two before that issue is actually resolved. In the interim, there's little reason the current implementation couldn't go ahead and do this now. This would result in the following behavior as related to the reported issue.
I can put together a CL this weekend if this sounds ok. |
In this particular case (the basic example), the manifest file is the default one filled by gomobile tool. https://github.com/golang/mobile/blob/master/cmd/gomobile/manifest.go#L64 In case a custom manifest file is given, yes, I think it's okay to abort and output helpful error message. Assigning to @dskinner. Thanks! |
thanks to all. |
CL https://golang.org/cl/16843 mentions this issue. |
Fixes golang/go#13172 Change-Id: I16cab3f74f668ce3522a1a14c979aca5c988347c Reviewed-on: https://go-review.googlesource.com/16843 Reviewed-by: David Crawshaw <crawshaw@golang.org>
Fixes golang/go#13172 Change-Id: I16cab3f74f668ce3522a1a14c979aca5c988347c Reviewed-on: https://go-review.googlesource.com/16843 Reviewed-by: David Crawshaw <crawshaw@golang.org>
Fixes golang/go#13172 Change-Id: I16cab3f74f668ce3522a1a14c979aca5c988347c Reviewed-on: https://go-review.googlesource.com/16843 Reviewed-by: David Crawshaw <crawshaw@golang.org>
I build basic example, but it crashed. gomobile suported old android?
The text was updated successfully, but these errors were encountered: