Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: make all logs URLs permanent #13076

Closed
bradfitz opened this issue Oct 28, 2015 · 2 comments
Closed

x/build/cmd/coordinator: make all logs URLs permanent #13076

bradfitz opened this issue Oct 28, 2015 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

No matter what scary text I put in the URL, people still link to farmer.golang.org's emphemeral build logs.

Perhaps farmer.golang.org should start recording all its streamed state to GCS and make sure that all emphemeral build log URLs have enough information in them to fetch the old logs from GCS if the build is not currently in progress.
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Oct 28, 2015
@bradfitz bradfitz self-assigned this Oct 28, 2015
@bradfitz bradfitz added this to the Unreleased milestone Oct 28, 2015
@gopherbot
Copy link

CL https://golang.org/cl/21968 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Apr 13, 2016
@bradfitz
cmd/coordinator: give each build and try set a globally unique random ID
e42afb7 
These IDs will become the cloud datastore keys for keeping history and logs.

Many more CLs will follow: changing farmer URLs, logging to datastore,
fetching old logs from datastore, etc.

Updates golang/go#13076 (make all logs URLs permanent)
Updates golang/go#12669 (collect logs, stats)

Change-Id: I5b9fd21bf23581c59724b0ed32c8459baa9683f7
Reviewed-on: https://go-review.googlesource.com/21968
Reviewed-by: Andrew Gerrand <adg@golang.org>
@bradfitz bradfitz mentioned this issue Sep 21, 2016
Closed
@bradfitz bradfitz mentioned this issue Feb 11, 2017
Closed
@quentinmit quentinmit mentioned this issue Apr 6, 2017
Closed
@dmitshur dmitshur added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 19, 2019
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 19, 2019
@dmitshur dmitshur changed the title x/build/coordinator: make all logs URLs permanent x/build/cmd/coordinator: make all logs URLs permanent Jun 19, 2019
@toothrot toothrot mentioned this issue Sep 5, 2019
Open
@dmitshur
Copy link
Contributor

dmitshur commented Sep 5, 2019

I'll close this 2015 issue in favor of #34119, which supersedes it.

This issue describes fairly low level implementation details, and coordinator may have changed since 2015. We can open new specific issues to track this work as needed.

@dmitshur dmitshur closed this as completed Sep 5, 2019
@golang golang locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot