-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: retire/repair disabled compiler behavior tests #13068
Comments
CL https://golang.org/cl/16299 mentions this issue. |
Some tests disabled, some bifurcated into _ssa and not, with appropriate logging added to compiler. "tests/live.go" in particular needs attention. SSA-specific testing removed, since it's all SSA now. Added "-run_skips" option to tests/run.go to simplify checking whether a test still fails (or how it fails) on a skipped platform. The compiler now compiles with SSA by default. If you don't want SSA, specify GOSSAHASH=n (or N) as an environment variable. Function names ending in "_ssa" are always SSA-compiled. GOSSAFUNC=fname retains its "SSA for fname, log to ssa.html" GOSSAPKG=pkg only has an effect when GOSSAHASH=n GOSSAHASH=10101 etc retains its name-hash-matching behavior for purposes of debugging. See #13068 Change-Id: I8217bfeb34173533eaeb391b5f6935483c7d6b43 Reviewed-on: https://go-review.googlesource.com/16299 Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: David Chase <drchase@google.com>
Ping @dr2chase |
|
CL https://golang.org/cl/23290 mentions this issue. |
live_ssa.go -> live.go and nilptr3_ssa.go -> nilptr3.go happened after the legacy backend was deleted. (David, live.go has ppc64 disabled - can we reenable it?) |
Not yet:
|
SSA has different behavior from the previous backend, and some tests probe this behavior.
In some cases this can be repaired by changes to SSA (i.e., it does the same thing, but doesn't log it or logs it differently) and in other cases SSA just plain does things differently (for example, it removes nil checks very aggressively and so the nil checks emitted do not match). To allow the tests to run successfully with SSA both enabled and disabled, some of them must be disabled until this is resolved.
Affected tests:
See https://golang.org/cl/16299
The text was updated successfully, but these errors were encountered: