Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sync: create subrepo #13058

Closed
bradfitz opened this issue Oct 27, 2015 · 5 comments
Closed

x/sync: create subrepo #13058

bradfitz opened this issue Oct 27, 2015 · 5 comments
Labels
FrozenDueToAge Proposal

Comments

@bradfitz
Copy link
Contributor

@Sajmani, @adg and I want to create the golang.org/x/sync subrepo for synchronization-related packages.

In particular,

  1. singleflight (https://godoc.org/camlistore.org/pkg/singleflight and https://godoc.org/internal/singleflight and google's internal copy, all slightly different because there's no common spot)
  2. Group (launch goroutines + capture errors + be a WaitGroup.... https://godoc.org/camlistore.org/pkg/syncutil#Group and Google's internal copy, also diverging).

This has grown more important because http2 wants to use singleflight, but http2 is in x/net and internal/singleflight is stdlib-only internal. I want to put it in x/sync so both stdlib and x/net/http2 can share the same vendored copy (and delete the internal copy).

Further, sameer and @bcmills want to open source some google stuff which requires a home.

x/tools turned into a dumping group, and now x/net is at risk of turning into a dumping ground.

Hence: x/sync for these sync-related things.

/cc @rsc @adg
@adg
Copy link
Contributor

adg commented Oct 27, 2015

SGTM

@davecheney
Copy link
Contributor

SGTM. I am in favour of this trend towards smaller, more focused subrepos.

On Tue, Oct 27, 2015 at 11:18 AM, Andrew Gerrand notifications@github.com
wrote:

SGTM

—
Reply to this email directly or view it on GitHub
#13058 (comment).

@rsc
Copy link
Contributor

rsc commented Oct 29, 2015

LGTM

@rsc rsc changed the title Proposal: create x/sync subrepo proposal: x/sync: create subrepo Oct 29, 2015
@gopherbot
Copy link

CL https://golang.org/cl/16506 mentions this issue.

@adg
Copy link
Contributor

adg commented Oct 30, 2015

The repo is created.

adg added a commit to golang/build that referenced this issue Oct 30, 2015
@adg
app/build, cmd/pushback: add sync repo
476aff7 
Update issue golang/go#13058

Change-Id: I24e136b955e7556af2c24c25b10f6d4abb630dbd
Reviewed-on: https://go-review.googlesource.com/16506
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@davecheney davecheney mentioned this issue Oct 30, 2015
Closed
@rsc rsc changed the title proposal: x/sync: create subrepo x/sync: create subrepo Oct 30, 2015
@rsc rsc closed this as completed Oct 30, 2015
@SchumacherFM SchumacherFM mentioned this issue Oct 4, 2016
Closed
@golang golang locked and limited conversation to collaborators Nov 4, 2016
@rsc rsc unassigned adg Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bradfitz @davecheney @rsc @adg @gopherbot