-
Notifications
You must be signed in to change notification settings - Fork 18k
x/mobile/cmd/gomobile: ordering of manifest attributes may produce invalid manifest #13036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
My initial reaction is to disable sorting of test results. Repeated encoding of the same manifest with the
|
cc @crawshaw |
I've started working to resolve. Will also provide real testing down to byte-to-byte level, testing of any number of manifests, and have it setup so results can be tested against any future version of the sdk build-tools. |
I forgot to mention localized testing down to the chunk header as well so any future errors can be more easily identified. |
Here's a more formal proposal for how I plan to fix this (most of this is already working, the following being a header in the source):
|
this has been addressed with #13109 |
This subtle difference is not picked up in the tests since
aapt
will still successfully match the parsed xmltree against its own encoding of the same xml. The exact reason for the fault is yet unknown but can be worked around be reordering attributes in an apps manifest.The text was updated successfully, but these errors were encountered: