-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/time: create new subrepo for x/time/rate, other code #13022
Comments
The "net" repo seems the obvious place for this, to me. But my opinion aside, issue #12914 is a request for a monotonic clock On 23 October 2015 at 03:32, Sameer Ajmani notifications@github.com wrote:
|
There's nothing about networking in the package Sameer is talking about. It's important that net not become a dumping ground for "anything a server might want". I think x/time is reasonable. One might envision calendar code going there too. Who knows? Maybe even monotonic time support, although I am less convinced of that. Anyway, an x/time repo seems reasonable. /cc @robpike |
Yes, my argument to Sameer was that "tools" became a dumping ground and now "net" is becoming a dumping ground. We also have a few things pending perfect for an "x/sync" subrepo if there were one. Rather than thinking that a subrepo has a high cost, we should really think of a subrepo as a subdirectory of "x" where you can think of "x" as the same as, say, "google3". |
I agree with @bradfitz we should be creating more repositories. I'm not familiar with the rate package; it sounded intrinsically On 24 October 2015 at 16:32, Brad Fitzpatrick notifications@github.com
|
LGTM. Leaving for adg@ to create the subrepo. |
Thank you! On Tue, Nov 3, 2015 at 1:58 AM, Andrew Gerrand notifications@github.com
|
I would like to open-source a package
rate
that we developed at Google. It provides a rate limiter that supports Context for cancelation and deadlines: a caller can block until either the rate limiter allows the call to proceed or the Context is canceled. It includes an optimization to skip the wait if it would exceed the Context's Deadline. This package is widely used inside Google Go code.There is no obvious home for this package in any of the golang repositories, so I propose we add a new subrepo, golang.org/x/time, that will contain the rate package as golang.org/x/time/rate. To justify the creation of a new subrepo, it would be useful to identify additional packages that belong here.
The text was updated successfully, but these errors were encountered: