Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/cmd/gomobile: support resource type theme in android manifest #13018

Closed
dskinner opened this issue Oct 21, 2015 · 1 comment
Closed

x/mobile/cmd/gomobile: support resource type theme in android manifest #13018

dskinner opened this issue Oct 21, 2015 · 1 comment
Labels
FrozenDueToAge

Comments

@dskinner
Copy link
Member

While it'd be good to work out a programmatic api for going in and out of full screen mode (see #12766), referencing a fullscreen theme in android manifest is always going to be the best way to bootstrap an activity intended to start in fullscreen mode to avoid jitter.

This has no bearing on a compatible method across platforms, this is only regarding the encoding of a developers AndroidManifest.xml
@gopherbot
Copy link

CL https://golang.org/cl/16159 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 24, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@dskinner @crawshaw
cmd/gomobile: support manifest theme with new reference type
1ece6c9 
Style identifiers for included themes were selected based on
api level <= 9.

Fixes golang/go#13018

Change-Id: I6be19a90b65ad5cbd78ff73fe2d9a71b8e3908ca
Reviewed-on: https://go-review.googlesource.com/16159
Reviewed-by: David Crawshaw <crawshaw@golang.org>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@dskinner @crawshaw
cmd/gomobile: support manifest theme with new reference type
12f0a27 
Style identifiers for included themes were selected based on
api level <= 9.

Fixes golang/go#13018

Change-Id: I6be19a90b65ad5cbd78ff73fe2d9a71b8e3908ca
Reviewed-on: https://go-review.googlesource.com/16159
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dskinner @gopherbot