Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/mobile/cmd/gomobile: select android build-tools compatibility criteria #13015

Closed
dskinner opened this issue Oct 21, 2015 · 1 comment

Comments

@dskinner
Copy link
Member

Currently, the only criteria was based on a hex dump of an unidentified version of the build-tools for generating manifest file. In other areas of x/mobile, it can be based on the last directory in the build tools folder which is inadequate (e.g. I have an android-4.4W folder in my build-tools/ from sdk). With CL16150, the latter has become the case for testing binaryXML output, but this needs to stop.

The general premise is that updated sdk build-tools will be backwards compatible with the output of older build-tools (the degree to which is undefined, some research on this would be nice). Picking a build-tools version to emulate would then provide some minimum guarantees to reproducible tests and general longevity.

One impediment I see to this is the distribution of build-tools versions. About how long does it take before a version is no longer available through android sdk? If this is an issue, would gomobile host the build tools similar to ndk bits?

With a version of the tools selected, tests could then perform a byte-to-byte comparison as done previously if so desired.

@crawshaw

@dskinner dskinner changed the title x/mobile/cmd/gomobile: select android build-tools compatibility criteria proposal: x/mobile/cmd/gomobile select android build-tools compatibility criteria Oct 23, 2015
@rsc rsc added this to the Proposal milestone Oct 24, 2015
@rsc rsc changed the title proposal: x/mobile/cmd/gomobile select android build-tools compatibility criteria proposal: x/mobile/cmd/gomobile: select android build-tools compatibility criteria Oct 24, 2015
@rsc rsc added the Proposal label Oct 24, 2015
@dskinner
Copy link
Member Author

dskinner commented Mar 5, 2016

this has been addressed in #13109

@dskinner dskinner closed this as completed Mar 5, 2016
@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants