Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text: internal/TestParents and language/TestCompactIndex are failing #12987

Closed
awalterschulze opened this issue Oct 19, 2015 · 8 comments
Closed

x/text: internal/TestParents and language/TestCompactIndex are failing #12987

awalterschulze opened this issue Oct 19, 2015 · 8 comments
Labels
FrozenDueToAge

Comments

@awalterschulze
Copy link

go 1.5
linux amd64

Also it would be nice it the golang/text repo's readme.md could provide a link to where it wants its issues reported, please.
@adg adg changed the title golang/text internal/TestParents and language/TestCompactIndex are failing x/text: internal/TestParents and language/TestCompactIndex are failing Oct 19, 2015
@adg adg assigned mpvl Oct 19, 2015
@mpvl
Copy link
Contributor

mpvl commented Oct 19, 2015

Thanks for the report. A fix is under review.

Sent out a fix. Note that all go repos, including this one, describe the contribution guidelines in CONTRIBUTING.md.

@mpvl
Copy link
Contributor

mpvl commented Oct 19, 2015

Fixed by CL 16011

@mpvl mpvl closed this as completed Oct 19, 2015
@awalterschulze
Copy link
Author

--- FAIL: TestLinking-8 (1.56s)
currency_test.go:151: size(symbols)-size(base) was 0; want > 2K

@awalterschulze
Copy link
Author

Seems not all tests are stable.

@mpvl
Copy link
Contributor

mpvl commented Oct 20, 2015

That one is unrelated. The remaining failures seem to be various issues
with the build environment. (Missing GOPATH and missing test files).

On Tuesday, October 20, 2015, Walter Schulze notifications@github.com
wrote:

Seems not all tests are stable.

—
Reply to this email directly or view it on GitHub
#12987 (comment).

Marcel van Lohuizen -- Google Switzerland GmbH -- Identifikationsnummer:
CH-020.4.028.116-1

@awalterschulze
Copy link
Author

That is the only test that is failing.
Could you please fix it?

@mpvl
Copy link
Contributor

mpvl commented Oct 20, 2015

I don't see it failing on the build dashboard and it passing for me
locally. Could you please file another bug with more context?

The test builds a couple of binaries to verify the linker is dropping
tables properly. Such tests are a bit finicky to get right.

On Tuesday, October 20, 2015, Walter Schulze notifications@github.com
wrote:

That is the only test that is failing.
Could you please fix it?

—
Reply to this email directly or view it on GitHub
#12987 (comment).

@awalterschulze
Copy link
Author

Ok weird I can't reproduce it now either.
I guess thats my bad. Sorry.

@golang golang locked and limited conversation to collaborators Oct 24, 2016
AlexanderYastrebov pushed a commit to AlexanderYastrebov/go that referenced this issue Oct 3, 2021
@mpvl
language: fixed test breakage
0fe7e68 
Missed some adjustments in the move from en-US-x-posix to
en-US-u-va-posix.

Fixes golang#12987.

Change-Id: Ie422598c955359556b4d0d244062b0bf267c022c
Reviewed-on: https://go-review.googlesource.com/16011
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@rsc rsc unassigned mpvl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@awalterschulze @mpvl @gopherbot