Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/bind: inconsistent include guards #12984

Closed
rakyll opened this issue Oct 19, 2015 · 1 comment
Closed

x/mobile/bind: inconsistent include guards #12984

rakyll opened this issue Oct 19, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@rakyll
Copy link
Contributor

rakyll commented Oct 19, 2015 

$ gomobile bind -target=ios -prefix Lib -o some.framework
$ cat some.framework/Headers/Hello.h
// Objective-C API for talking to golang.org/x/mobile/example/bind/hello Go package.
//   gobind -lang=objc -prefix=Lib golang.org/x/mobile/example/bind/hello
//
// File is generated by gobind. Do not edit.

#ifndef __GoHello_H__
#define __GoHello_H__

#include <Foundation/Foundation.h>

FOUNDATION_EXPORT NSString* LibHelloGreetings(NSString* name);

#endif

Expected result:

#ifndef __LibHello_H__
#define __LibHello_H__

/cc @hyangah
@rakyll rakyll added this to the Unreleased milestone Oct 19, 2015
@rakyll rakyll changed the title x/mobile/cmd/gomobile: inconsistent include guards x/mobile/bind: inconsistent include guards Oct 19, 2015
@gopherbot
Copy link

CL https://golang.org/cl/16027 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 24, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@rakyll
bind: use the prefix in the include guards
814121a 
Fixes golang/go#12984.

Change-Id: I485e6071ff136eb3f475d03ebebf8d306f24c931
Reviewed-on: https://go-review.googlesource.com/16027
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@rakyll
bind: use the prefix in the include guards
3dc1a9c 
Fixes golang/go#12984.

Change-Id: I485e6071ff136eb3f475d03ebebf8d306f24c931
Reviewed-on: https://go-review.googlesource.com/16027
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@rakyll @gopherbot